Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the sidebar logo for cred dashboard #14451

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

usamabinnadeem-10
Copy link
Contributor

@usamabinnadeem-10 usamabinnadeem-10 commented Oct 28, 2024

Done

  • Fix the sidebar logo on smaller screens

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes
  • Make sure the logo is clickable on smaller screens and is the same logo which you see on larger screens

Issue / Card

Fixes WD-16076

Help

QA steps - Commit guidelines

@webteam-app
Copy link

@@ -74,21 +74,28 @@ const Sidebar = () => {
<div className="l-navigation-bar">
<div className="p-panel is-dark">
<div className="p-panel__header">
<a className="p-panel__logo" href="/credentials" target="_blank">
<div
onClick={handleClickDashboard}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@usamabinnadeem-10 Why did we switch to using a div instead of the anchor tag? I feel like this would be bad for accessibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants