New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor removing config generation from the pebble service #123

Open

jdkandersson opened this issue Dec 11, 2023 · 1 comment

Contributor

jdkandersson commented Dec 11, 2023

Please refactor these lines moving the config generation to the event handler which can then use pebble service to restart.

https://github.com/canonical/synapse-operator/blob/eb44f4959a00040f08b98470f8b17cae4cc616da/src/pebble.py#L86C1-L106C57

Contributor Author

jdkandersson commented Dec 11, 2023

Also discussed with @gregory-schiano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment