Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check lint and test stdout step should report all missing dependencies in one pass #77

Open
merkata opened this issue Jan 16, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@merkata
Copy link
Contributor

merkata commented Jan 16, 2023

Currently, the Check lint and test stdout step checks for missing linting dependencies in the tox.ini file and exits as soon as one is not available. If more dependencies are missing, you would get a new error on every consecutive run. It is better to gather all missing dependencies and present this as an output and then fail, permitting the user to fix all missing deps at one pass.

@merkata merkata added the good first issue Good for newcomers label Jan 16, 2023
@jdkandersson
Copy link
Contributor

This would be great! Another change that could be good to include is to actually base the required linters on content on the https://github.com/canonical/is-charms-contributing-guide repo

@jdkandersson
Copy link
Contributor

As a workaround, this file can be check for which linters are required: https://github.com/canonical/operator-workflows/blob/main/tests/workflows/test/simple/tox.ini

@jdkandersson
Copy link
Contributor

The benefits of having tests 😉

@merkata
Copy link
Contributor Author

merkata commented Jan 17, 2023

The benefits of having tests wink

Exactly, it naturally gets you into a more structured way of reasoning and improving, I like it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants