Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about the cmake plugin alerting the user that cmake doesn't set release mode by default. #854

Open
lengau opened this issue Sep 24, 2024 · 2 comments
Assignees
Labels
Documentation Improvements or additions to documentation Enhancement New feature or request Triaged

Comments

@lengau
Copy link
Contributor

lengau commented Sep 24, 2024

What needs to get done

Add a note block to the cmake plugin reference calling out that it doesn't add any cmake parameters, so if the user wants to use release they should add -DCMAKE_BUILD_TYPE

Why it needs to get done

@dariuszd21 brought up the fact that the default may be debug.

@lengau lengau added Documentation Improvements or additions to documentation Enhancement New feature or request Triaged labels Sep 24, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3455.

This message was autogenerated

@dariuszd21
Copy link
Contributor

I duplicated it in #855 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Enhancement New feature or request Triaged
Projects
None yet
Development

No branches or pull requests

2 participants