Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daura clustering should return clusters as a ds-array with cluster ids #311

Open
salvisolamartinell opened this issue Sep 30, 2020 · 0 comments
Labels
algorithm related Issues that require algorithm understanding enhancement New feature or request

Comments

@salvisolamartinell
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Consistency between clustering algorithms.

Describe the solution you'd like
Daura clustering should return clusters as a ds-array with cluster ids. Numbering clusters by discovery order and 0-based would be logic. It should return another ds-array or list, of length n_clusters_found, with the centers of each cluster.

Describe alternatives you've considered
Leave it as it is, with a list of lists: a list of ids for each cluster. This is not consistent and does not use distributed arrays. We can consider this if the proposed solution is much slower. But we should try it first.

Additional context
The current version has been used successfully for a scientific application, but all the outputing needs to reviewed.

This was referenced Sep 30, 2020
@salvisolamartinell salvisolamartinell added algorithm related Issues that require algorithm understanding enhancement New feature or request labels Sep 30, 2020
@cTatu cTatu added this to the release 0.8 milestone Oct 10, 2022
@cTatu cTatu removed this from the release 0.8 milestone Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm related Issues that require algorithm understanding enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants