Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvise metrics collection #6

Open
3 tasks
joelrebel opened this issue Jan 1, 2019 · 1 comment
Open
3 tasks

improvise metrics collection #6

joelrebel opened this issue Jan 1, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@joelrebel
Copy link
Member

@joelrebel joelrebel added this to the bmcbutler v1.0 milestone Jan 1, 2019
@joelrebel joelrebel added the enhancement New feature or request label Jan 1, 2019
@paskal
Copy link
Contributor

paskal commented Apr 29, 2019

I think validating metrics collection is not worth it: it's not easy to mock and it's easier to detect visually on Grafana dashboard or wherever you send them instead of putting unit tests on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants