Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seller cannot see their own offer in offerbook if trade amount is higher than their current (buy side) account limit and the "Offers matching my accounts" toggle is enabled #7204

Open
cbeams opened this issue Jul 17, 2024 · 0 comments

Comments

@cbeams
Copy link
Member

cbeams commented Jul 17, 2024

This is an edge case I'd never seen before today.

Repro steps:

  1. Create a new SEPA account
  2. Create a sell offer for an amount higher than the new account buy limits
  3. Notice the offer creation succeeds and shows up in Portfolio > My Open Offers
  4. Now go to Market > Buy, select EUR in currency filter, select Show all in payment method filter, and enable the Offers matching my accounts toggle
  5. Notice that the offer created in step 2 (the user's own offer) does not show up in the list as expected
  6. Uncheck the Offers matching my accounts toggle
  7. Notice that the offer created in step 2 now shows up as originally expected, with its Remove and Edit buttons, etc.

Analysis:

The reason the user's own offer didn't show up in step 4 is because their account is still so new that they "could not take their own sell offer", and thus the offer gets hidden. It makes sense why this is happening, and it's arguably not a "bug" per se, but it is unintuitive, and took me several minutes to figure out what was really going on. I think it does actually qualify as a bug, though, because even if the account was old enough / signed enough, it would still never be the case that the user can take their own offer. The "buy" button does not even appear, only the Remove and Edit buttons.

Suggested fix:

It might require some special case handling, but I think that, so long as the offer book filter includes currency and payment method for a user's own offer, the offer should always show up, regardless whether the "Offers matching my accounts toggle" is enabled. This way, the user will always see their own offer when they would reasonably expect to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant