Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site tag in Game #17

Open
vixen opened this issue Mar 9, 2019 · 3 comments
Open

Site tag in Game #17

vixen opened this issue Mar 9, 2019 · 3 comments

Comments

@vixen
Copy link

vixen commented Mar 9, 2019

One suggestion :

  • Probably "Site" tag should be available in Game also

Reason lichess.org site puts specific game id in site tag in their pgn

Example

[Site "https://lichess.org/<gameid>"]

While u parse the pgn the only way to get site is via PGN's event map
and it only has site for last game of that event and there is now way we can get specific game id

@bhlangonijr
Copy link
Owner

Hello @vixen,

According to PGN spec Site is the location of the event. It seems a bit odd they use this field for storing the game id. Ideally they would make use of a custom field. Are there any other tools or websites using this tag for the same purpose? I mean I can sacrifice the spec for enabling a "de facto" interpretation of this tag.

@vixen
Copy link
Author

vixen commented Mar 12, 2019

Thanks for your reply
Your project is awesome
May be these events/games are online so location/site is an online url only

In case of human events also sometimes different rounds happen at different locations.
If I remember correctly once(may be more) for Linares first round happened at Moralia(Mexico) and second round at Linares (Spain).
Anway this is an exception rather than a norm
So feel free to take decision
Thanks

@bhlangonijr
Copy link
Owner

I'll go ahead and take your suggestion. The change should be available in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants