Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Chapter 2 cleanup notes ✏️ #515

Closed
12 of 13 tasks
rsese opened this issue Feb 26, 2019 · 1 comment · Fixed by #528
Closed
12 of 13 tasks

Chapter 2 cleanup notes ✏️ #515

rsese opened this issue Feb 26, 2019 · 1 comment · Fixed by #528

Comments

@rsese
Copy link
Contributor

rsese commented Feb 26, 2019

Ran through chapter 2, here are things I think we should update ✔️

There are other things that could be updated but tried to stick to things that are just wrong or could be confusing to a new user following along (e.g. there are more out of date screenshots but they're not out of date in a way that makes it super confusing to look at).

screenshots

https://flight-manual.atom.io/using-atom/sections/find-and-replace/

  • Find and replace screenshot is out of date (Find All button missing)
  • Project find and replace screenshot is out of date (Find All button missing, new results view controls missing)

cleanup

https://flight-manual.atom.io/using-atom/sections/atom-packages/

  • "there are more than 90 packages that comprise" - as of 1.34.0 the number of core packages is 81 (we started pulling in some packages into core).

https://flight-manual.atom.io/using-atom/sections/find-and-replace/

  • "or Cmd+G or the "Find Next" button" - related to updating the screenshot, mention the Find All keybinding)
  • /s/javascript/JavaScript

https://flight-manual.atom.io/using-atom/sections/snippets/

  • html snippet is out of date
    • relatedly, the description of where your cursor will be is out of date

https://flight-manual.atom.io/using-atom/sections/version-control-in-atom/

  • Might need an update or merging with https://flight-manual.atom.io/using-atom/sections/github-package/? Or at least a reference/segue to the GitHub package page.
    • Written pre-GitHub package I think, kinda odd to have the pages separate e.g. this page says "Version control is an important aspect of any project and Atom comes with basic Git and GitHub integration built in." and the GitHub package page says "The github package brings Git and GitHub integration right inside Atom."

https://flight-manual.atom.io/using-atom/sections/writing-in-atom/

https://flight-manual.atom.io/using-atom/sections/basic-customization/

  • "An environment variable can be used, though to make Atom" - remove the ", though"
  • "The environment variable used to specify and alternate location is called ATOM_HOME" - I believe that's "an alternate location"
  • "Another way to find the scope for a specific language is to open a file of its kind and press Alt+Ctrl+Shift+P to" - keybinding removed at some point, not available on Windows or Linux. Should update to mention command palette command.
@rsese
Copy link
Contributor Author

rsese commented Apr 29, 2019

https://flight-manual.atom.io/using-atom/sections/version-control-in-atom/

Didn't do this one, felt like it could be a larger change - opened #529 to track it ✏️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant