Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry initialization with an option that not added to a datapack #831

Open
hepengfe opened this issue Jun 9, 2022 · 1 comment
Open
Assignees
Labels
topic: data Issue about data loader modules and data processing related topic: ontology All issues related to ontologies in core, top and base_ontology

Comments

@hepengfe
Copy link
Collaborator

hepengfe commented Jun 9, 2022

Is your feature request related to a problem? Please describe.
Every time I create a new ontology entry type, when I implement and test the new entry, I have to add code in DataPack and DataStore to test its behavior or pass CI test. I think we should have an option here such that we can "not adding entry to datapack".

Describe the solution you'd like
solution1: make pack: ContainerType optional and when it is None, we don't add entry to datapack.

Describe alternatives you've considered
solution2: add a boolean parameter skip_add, and when it's True we don't add entry to datapack.

Additional context
We might also want to raise warnings in some places when an entry is standalone and users call some datapack-dependent methods.

@hepengfe hepengfe added topic: data Issue about data loader modules and data processing related topic: ontology All issues related to ontologies in core, top and base_ontology labels Jun 9, 2022
@hepengfe hepengfe self-assigned this Jun 9, 2022
@hepengfe
Copy link
Collaborator Author

One issue with either make pack optional or add parameter skip_add is that for ontology subclasses, they all need to have such a parameter/optional datapack therefore it involves a lot of changes and adds complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: data Issue about data loader modules and data processing related topic: ontology All issues related to ontologies in core, top and base_ontology
Projects
None yet
Development

No branches or pull requests

1 participant