Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record logic for some processors may be wrong #68

Open
hunterhector opened this issue Aug 17, 2021 · 0 comments
Open

Record logic for some processors may be wrong #68

hunterhector opened this issue Aug 17, 2021 · 0 comments
Assignees

Comments

@hunterhector
Copy link
Member

hunterhector commented Aug 17, 2021

Describe the bug
For example, in the Spacy record function:
https://github.com/asyml/forte-wrappers/blob/main/src/spacy/forte/spacy/spacy_processors.py#L280

The record_meta for the Sentence type is first set to an empty set. However, this may not be true if there are existing processors that already add Sentences.

The problem is that what should we do when two processors both add the Sentence type? We probably should maintain separate records for each processor, something like:

{
    "spacy": "ft.onto.base_ontology.Token": {"ner", "pos"}
    "stanza": "ft.onto.base_ontology.Token": {"lemma", "pos"}
}
``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants