-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for generating (all) diagram types Asciidoctor Diagram supports #66
Comments
Hello @7SW , thanks a lot for pushing on this! The elements you have attached are a very useful: it will helps us to handle all the non regression tests cases. Theorically, all diagrams should work as before, but the move to alpine linux had some side effects: some use cases see their tooling installed, but without a test, it crash at runtime, as in #58 . It is why I say again: THANK YOU for your use case here! Next step: opening a pull request with those implemented (and eventually fixes alongside if the tests are failing in the current state). By the way, expect at least an ETA at the end of January: there are 4 pull requests staling (holidays and I suppose the other maintainers have a lot of things to do so their free time is not always allowing them to review carefully). Hope it helps |
Has this issue been resolved, or are there still diagram types that are not working under Alpine? |
o = fails Conclusion: sure works better than before :-), but some diagrams don't generate an image in any format in my test. Most notably: Mermaid, Umlet.. but also erd, shaape, and wavedrom. Most pdf generation fails with: two plantuml ditaa tests fail, but I think rendering ditaa diagrams with ditaa itself is the better option anyway... Also, sizing of some images in PDF is not right. Could be an issue with the test doc itself though. |
Thanks for doing this assessment, @7SW! I'm not sure the PDF format is even a goal for Asciidoctor Diagram. Or is it? So that column may not be relevant in this context. Correct me if I'm wrong. I also would challenge whether it's a goal to create all diagram types that Asciidoctor Diagram supports. We might end up getting diminishing returns compared to the increase in image size. The goal is to create a solid base image with the functionality that most users would need. mermaid and shaape are certainly very popular, but I'm not as sure about umlet for instance. Then again, I don't create many diagrams, so I'm just going based on the discussions I see go by. |
Vega and Vega-lite libraries are also missing:
As this issue is still open since 2018, is there some news about it ? |
Hi and thanks for the great job done on this docker image. For the record, I would be really interested in vega/vegalite support. One question: I don't know more about docker than using an image. What are the skills needed to help this project (and this specific issue)? |
Bytefield-svg would be very useful as well. |
I managed to get bytefield-svg and wavedrom working for me in docker; Dockerfile can be found here. |
I'm building a full blown Asciidoctor Container Image with all Asciidoctor Diagrams extensions. Github: https://github.com/barthel/docker-asciidoctor |
What diagram types are supported bij the asciidoctor docker image 'out of the box'?
Until last release (did not test the januari release yet) these were supported:
Best situation would be that all of the formats mentioned at:
http://asciidoctor.org/docs/asciidoctor-diagram/
are supported. Personally i miss blockdiag and mermaid most.
To test support I made the .adoc attached. I hope it can be of use. I can update it to include all of the diagrams mentioned at this moment in all formats (see link above): just let me know.
adoc-diagram-testdoc.adoc.zip
Keep up the good work :-)!
Maarten
The text was updated successfully, but these errors were encountered: