Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Twitter card for profiles #1793

Open
broskoski opened this issue Feb 12, 2019 · 6 comments
Open

Missing Twitter card for profiles #1793

broskoski opened this issue Feb 12, 2019 · 6 comments

Comments

@broskoski
Copy link
Member

On jade rendered routes, we currently automatically populate twitter cards for the given page:

meta(name="twitter:card", content="summary_large_image")

After switching to React rendered profiles, these tags are no longer present. Check for cards here: https://cards-dev.twitter.com/validator

After looking into this for ten minutes, I actually thought it would be preferable to make a field specifically for this in GraphQL (i.e. meta_images that would just return an array of images from the given profile.

Something else to consider is only rendering these meta tags for social bot / agents: https://stackoverflow.com/questions/29261733/detect-social-bots-in-node-express

@dzucconi
Copy link
Member

Ah when I looked at this I assumed we didn't have images for profiles. Yes I would write a custom node and return a single image for it. Why not avatar though?

@broskoski
Copy link
Member Author

I think avatar is probably more logical, but it would probably just look shitty most of the time. To be clear we are talking about these cards:
screen shot 2019-02-12 at 4 09 59 pm

@dzucconi
Copy link
Member

Can you check if twitter cards invoke client-side code?

@broskoski
Copy link
Member Author

@broskoski
Copy link
Member Author

More context here: nfl/react-helmet#26

@dzucconi
Copy link
Member

Right that's fine. I'd just add a node and add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants