Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Project: Remove unused references #761

Open
sadukie opened this issue Jul 3, 2024 · 2 comments
Open

Web Project: Remove unused references #761

sadukie opened this issue Jul 3, 2024 · 2 comments

Comments

@sadukie
Copy link
Contributor

sadukie commented Jul 3, 2024

Running Clean Architecture template 9.1.2 with .NET 8.0.300

Saw these in the Web project. Are these still needed?

  <PackageReference Include="Microsoft.EntityFrameworkCore.Design" />
   <PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" PrivateAssets="All" />

I removed them from my project locally and am not seeing any side effects.

@sadukie sadukie changed the title WebProject: Remove unused references Web Project: Remove unused references Jul 3, 2024
@Emopusta
Copy link
Contributor

Emopusta commented Sep 5, 2024

Hello,

First of all, if you remove Microsoft.EntityFrameworkCore.Design you won't be able to use migration or update database at the initialization of the project because it includes dotnet ef migrations ... etc. so this package necessary for database initialization operations.

In the other hand, Microsoft.VisualStudio.Web.CodeGeneration.Design seems auto added when the scaffolding operation. I am depending on this stackoverflow answer about scaffolding auto package addition. I searched inside the repo and I could not find anything about dotnet aspnet-codegenerator * except #12 pull request but it has lack of relevancy with this situation so we may delete that package.

@Emopusta
Copy link
Contributor

Hello,

With this #812 Pull Request I concluded this issue. If there is no other problem relevant to this issue can you complete this issue @sadukie. Thank you.

Best Regards,

Emre Duman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants