Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: replace non-w3c commands with mobile:, and add deprecation message if needed #602

Open
KazuCocoa opened this issue Apr 14, 2023 · 8 comments

Comments

@KazuCocoa
Copy link
Member

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

See appium/java-client#1883

We're going to move non-w3c endpoint call to mobile (macos for mac2 driver etc) command, eventually, in the server side. Clients also want to follow the way.

Describe the solution you'd like
A clear and concise description of what you want to happen.

  • Remove non-w3c endpoint call, instead calls mobile extension command properly
  • Mark non-w3c endpoint call as deprecate

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@laolubenson
Copy link
Collaborator

@KazuCocoa has a mobile extension been created for every non-w3c command? Or just the app management endpoints?

@KazuCocoa
Copy link
Member Author

Maybe already exists:
e.g. https://github.com/appium/appium-uiautomator2-driver

Potentially some are not, then we should add them in the server side

@KazuCocoa
Copy link
Member Author

Each driver repository may have the list in the documentation

@Dor-bl
Copy link
Collaborator

Dor-bl commented May 5, 2023

@laolubenson are you taking this? or should I add it to my TO-DO?

@laolubenson
Copy link
Collaborator

@laolubenson are you taking this? or should I add it to my TO-DO?

@Dor-bl I'll pick this up.

@Dor-bl
Copy link
Collaborator

Dor-bl commented Sep 28, 2023

@Dor-bl Dor-bl changed the title [Feat]: This was referenced 13 minutes ago replace non-w3c commands with mobile:, and add deprecation message if needed [Feat]: replace non-w3c commands with mobile:, and add deprecation message if needed Sep 28, 2023
@Dor-bl
Copy link
Collaborator

Dor-bl commented Apr 12, 2024

@KazuCocoa, do you mean deprecating this region at first? https://github.com/appium/dotnet-client/blob/main/src/Appium.Net/Appium/AppiumDriverCommand.cs#L19C53-L19C53

@KazuCocoa, do you have any input here?

@KazuCocoa
Copy link
Member Author

yea, it looks correct. Perhaps not all commands already have mobile:, or still need to keep the command, but basically yes.

At least the file's commands will be via mobile: eventually or can simply drop as it no longer works. Some could keep as current deprecation comments for now as dotnet client v5, and can drop them as client v6 later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants