Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Add ENABLE_TLS option #331

Open
beef9999 opened this issue Jan 16, 2024 · 2 comments
Open

[Discussion] Add ENABLE_TLS option #331

beef9999 opened this issue Jan 16, 2024 · 2 comments

Comments

@beef9999
Copy link
Collaborator

beef9999 commented Jan 16, 2024

We already have the ENABLE_SASL option which is default OFF, and we used to regard that SSL module is a MUST HAVE.

But the SSL init in net/security-context/tls-stream.cpp will register Photon mutex, and will potentially cause core dumps if the app has used other third-party libs depends on SSL.

Since we can't remove all the third-party which might still be using std::threads, we sometimes need to disable SSL in Photon.

The new ENABLE_TLS option will only affect RPC client and HTTP client, and can defaults to ON.


Another option is not to add this option, but to change RPC client API. If not passing a TLSContext*, the TLS stream will not be initialized, so the SSL global init will not be called.

@jiangdongzi
Copy link

IMO TLS is misleading. Developers may think it means thread local storage

@lihuiba
Copy link
Collaborator

lihuiba commented Feb 4, 2024

IMO TLS is misleading. Developers may think it means thread local storage

Yes, I believe so. I once had such confusion. Is there any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants