Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logical def] Logical definition for epithelial cell of esophagus is missing #1

Open
aleixpuigb opened this issue May 14, 2023 · 1 comment · May be fixed by #4 or #5
Open

[Logical def] Logical definition for epithelial cell of esophagus is missing #1

aleixpuigb opened this issue May 14, 2023 · 1 comment · May be fixed by #4 or #5
Labels
good first issue Good for newcomers

Comments

@aleixpuigb
Copy link
Owner

CL term
epithelial cell of esophagus (CL:0002252)

Suggested revision of logical definition
'epithelial cell' and ('part of' some esophagus)

@aleixpuigb aleixpuigb added the good first issue Good for newcomers label May 14, 2023
@aleixpuigb aleixpuigb self-assigned this May 14, 2023
@aleixpuigb
Copy link
Owner Author

aleixpuigb commented May 14, 2023

Steps to follow:

  • Create a new branch in Github desktop
  • In protégé, open the ontology and make the edits.
  • Save the file in protégé.
  • In Github Desktop create the pull request (PR):
    • Commit the changes.
    • Push the commit.
    • Create pull request.
  • Link the PR to the issue.
  • Tag a reviewer.
  • Once the reviewer accept the edits, merge the branch to master.

To know more about ontology edition:

@aleixpuigb aleixpuigb removed their assignment May 15, 2023
aleixpuigb added a commit that referenced this issue May 16, 2023
Fixes #1  logical definition epithelial cell of esophagus
CamiloAlbornoz added a commit that referenced this issue May 16, 2023
Fixes #1 logical definition
@RubaAlkhalaf RubaAlkhalaf self-assigned this May 16, 2023
sb930 added a commit that referenced this issue May 16, 2023
Addresses #1 logical definition
cbarcl01 added a commit that referenced this issue May 16, 2023
Added a invalid comment to #1 epithelial cell issue for training only
A2l1ne added a commit that referenced this issue May 16, 2023
Addresses #1 logical definition epithelial cells
@A2l1ne A2l1ne linked a pull request May 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
2 participants