Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spock-core should have a reroute >= 0.7 constraint #180

Open
sternenseemann opened this issue Jul 26, 2022 · 2 comments
Open

Spock-core should have a reroute >= 0.7 constraint #180

sternenseemann opened this issue Jul 26, 2022 · 2 comments

Comments

@sternenseemann
Copy link

Otherwise compilation will fail with:

[8 of 8] Compiling Web.Spock.Core   ( src/Web/Spock/Core.hs, dist/build/Web/Spock/Core.o, dist/build/Web/Spock/Core.dyn_o )

src/Web/Spock/Core.hs:26:5: error:
    Not in scope: type constructor or class ‘AltVar’
   |
26 |     AltVar (..),
   |     ^^^^^^^^^^^

Adjusting the bound via a Hackage revision probably prevents people from running into this by accident, which seems kind of likely since stackage LTS 19 pins reroute to 0.6.
@sternenseemann
Copy link
Author

Additionally, it seems to me that 0.14.0.1 is an PVP violation, it should have been 0.14.1.0 since it newly exported AltVar?!

sternenseemann added a commit to NixOS/nixpkgs that referenced this issue Jul 26, 2022
@sternenseemann
haskellPackages.Spock-core: build with correct reroute version
57055b6 
Spock-core 0.14.0.1 now only supports reroute >= 0.7 because it exports
the new AltVar type (in an [PVP violation]).

We can luckily accomodate Spock-core, since all other [reverse deps] of
reroute are marked broken in nixpkgs at the moment.

[PVP violation]: agrafix/Spock#180 (comment)
[reverse deps]: https://packdeps.haskellers.com/reverse/reroute
@Zialus Zialus mentioned this issue Aug 2, 2022
Open
@Bodigrim
Copy link

Bodigrim commented Nov 1, 2022

As a Hackage trustee I made the necessary revision:
https://hackage.haskell.org/package/Spock-core-0.14.0.1/revisions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bodigrim @sternenseemann