Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Block] Transform from Post Comments block (depricated) -> Comments Query Loop block #40223

Closed
paaljoachim opened this issue Apr 11, 2022 · 4 comments
Assignees
Labels
[Block] Comments (legacy) The legacy mode of the Comments block (formerly known as Post Comments) [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

What problem does this address?

It would be helpful to make it easier to transform between between Post Comments block <-> Comments Query Loop block.

What is your proposed solution?

Add the transform here:
Screenshot 2022-04-11 at 13 21 45

@paaljoachim paaljoachim added [Type] Enhancement A suggestion for improvement. [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Block] Comments (legacy) The legacy mode of the Comments block (formerly known as Post Comments) labels Apr 11, 2022
@paaljoachim paaljoachim changed the title Transform between Post Comments block <-> Comments Query Loop block [Block] Transform between Post Comments block <-> Comments Query Loop block Apr 11, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 11, 2022
@paaljoachim paaljoachim changed the title [Block] Transform between Post Comments block <-> Comments Query Loop block [Block] Transform from Post Comments block (depricated) -> Comments Query Loop block Apr 11, 2022
@ockham
Copy link
Contributor

ockham commented Apr 11, 2022

Hey @paaljoachim, we've considered adding a transform from Post Comments to Comments Query Loop. However, since it would be somewhat complex to implement, we didn't want to make it a blocker that would prevent us from including the new Comments blocks with WP 6.0. Instead, we've opted to deprecate the Post Comments block for now (also hiding it from the inserter).

Furthermore, there's a bit of precedent of blocks like these co-existing, without necessarily adding a transform: IIUC, we still provide the "Latest Posts" block and haven't yet added a transform to transform it into a Posts Query Loop. (Not saying that it's ideal, just that there's precedent.)

I think that we're still considering adding a transform from Post Comments to Comments Query Loop in the long run (but not in time for WP 6.0). I'll defer to @SantosGuillamot who might have a more definitive answer 😄

@paaljoachim
Copy link
Contributor Author

Thanks for the comment @ockham Bernie!

@ockham
Copy link
Contributor

ockham commented Jul 28, 2022

We've now merged (#41807) the legacy Post Comments block into the new Comments block (formerly known as Comments Query Loop). This includes a button to transform the "legacy" version of the block (i.e. Post Comments) into the new version (Comments).

This is pretty similar in spirit to what this issue was requesting, so I think we can close it 🙂

@ockham ockham closed this as completed Jul 28, 2022
@paaljoachim
Copy link
Contributor Author

Great! Thank you!

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments (legacy) The legacy mode of the Comments block (formerly known as Post Comments) [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants