Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robo.js - Make multi-arg for options optional #331

Open
Pkmmte opened this issue Oct 22, 2024 — with Volta.net · 1 comment
Open

robo.js - Make multi-arg for options optional #331

Pkmmte opened this issue Oct 22, 2024 — with Volta.net · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

Copy link
Member

Pkmmte commented Oct 22, 2024

Currently, our Robo CLI handler returns the entire string between options. This is problematic for options that only need a single value like -k --kit which will never have a value with spaces.

Worse yet, this means we cannot currently use any option before the positional args.

npx create-robo -k activity myactivity

The above assigns "activity myactivity" to the kit option rather than recognizing myactivity as the positional argument.


File: cli-handler.ts

https://github.com/Wave-Play/robo.js/blob/main/packages/robo/src/cli/utils/cli-handler.ts

@Rishi-0007
Copy link

Hi @Pkmmte,
Please check and review the PR. Let me know if any further changes are needed to solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants