Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: More complete message rendering #119

Open
Im-Fran opened this issue Oct 15, 2022 · 5 comments
Open

[Enhancement]: More complete message rendering #119

Im-Fran opened this issue Oct 15, 2022 · 5 comments
Labels
enhancement New feature or request ui User interface-related issues

Comments

@Im-Fran
Copy link
Contributor

Im-Fran commented Oct 15, 2022

Enhancement

Render @mentions as the official client does.

Current Behaviour

Mentions are shown as raw text, in the form <@user id>

Desired Behaviour

Mentions should be rendered with the user name of the mentioned user, e.g. @CryptoAlgo Team

Screenshots

Here is a ping from someone else to me, is not shown as @Fran but as raw text with my user id
Screenshot 2022-10-15 at 13 31 26

@Im-Fran Im-Fran added bug Something isn't working triage Waiting for this issue to be triaged labels Oct 15, 2022
@cryptoAlgorithm
Copy link
Member

This is not a bug, all mentions aren't parsed yet. Obviously, this is something I'd like to change, but swiftUI makes it particularly hard with its extremely restricted AttributedString. Our contributors and I have attempted to add rendering for emotes and mentions but got nowhere.

@cryptoAlgorithm cryptoAlgorithm added enhancement New feature or request ui User interface-related issues and removed bug Something isn't working triage Waiting for this issue to be triaged labels Oct 17, 2022
@cryptoAlgorithm cryptoAlgorithm changed the title [Bug]: Pings are not being properly shown [Enhancement]: Pings are not being properly shown Oct 17, 2022
@Im-Fran
Copy link
Contributor Author

Im-Fran commented Oct 17, 2022

I could try to fix it, but I would need time to look at the code and understand on how the text is parsed. Also it might not be a good work cuz I just started learning SwiftUI xD

@Im-Fran
Copy link
Contributor Author

Im-Fran commented Oct 17, 2022

But the project does have like a parser for the discord markdown, right? Isn't it possible to add another parser to that package? that also can parse pings?

@cryptoAlgorithm
Copy link
Member

@Im-Fran nope, the md parsing is done by Text itself. it's a closed implementation with no way to extend it, unfortunately. Ahhh, apple thinking they know best again

@cryptoAlgorithm
Copy link
Member

Do join the Discord server to reach me faster :)

@cryptoAlgorithm cryptoAlgorithm changed the title [Enhancement]: Pings are not being properly shown [Enhancement]: More complete message rendering Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui User interface-related issues
Projects
Status: Backlog (Enhancements)
Development

No branches or pull requests

2 participants