Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String resources #81

Open
1 task done
eldcn opened this issue Aug 8, 2024 · 1 comment
Open
1 task done

String resources #81

eldcn opened this issue Aug 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@eldcn
Copy link
Contributor

eldcn commented Aug 8, 2024

Problem

Currently we are defining string resource in .kt files which makes it hard to handle localization

Solution

  • Extract all string resources defined in kotlin files under values/strings.xml of either app or the module owning the resource
  • Consider Android studio context menu to automatically extract: Select string > Show Context Actions > Extract string resource

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@eldcn eldcn added the enhancement New feature or request label Aug 8, 2024
@PSchmiedmayer
Copy link
Member

Would be great; localization is up on the agenda after the cross-institution launch. We should ensure that we have the bits and pieces in place for that.

@eldcn eldcn mentioned this issue Sep 15, 2024
Merged
1 task
eldcn added a commit that referenced this issue Sep 20, 2024
@eldcn
Record deletion (#100)
1adfb33 
# Deletion of records

## What is done
- Unify weight, blood pressure and heart rate view models into one
`HeartRateViewModel` to avoid duplicated logic
- Add confirmation alert for record deletion health tabs
- Unit test view model
- Added `StringResource` type to handle string properties of ui state
models (proposed in #81)


## ⚙️ Release Notes 
*Add a bullet point list summary of the feature and possible migration
guides if this is a breaking change so this section can be added to the
release notes.*
*Include code snippets that provide examples of the feature implemented
or links to the documentation if it appends or changes the public
interface.*


## 📚 Documentation
*Please ensure that you properly document any additions in conformance
to [Spezi Documentation
Guide](https://github.com/StanfordSpezi/.github/blob/main/DOCUMENTATIONGUIDE.md).*
*You can use this section to describe your solution, but we encourage
contributors to document your reasoning and changes using in-line
documentation.*


## ✅ Testing
*Please ensure that the PR meets the testing requirements set by CodeCov
and that new functionality is appropriately tested.*
*This section describes important information about the tests and why
some elements might not be testable.*


## 📝 Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [ ] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eldcn @PSchmiedmayer