Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking React 19 #362

Open
SeanCassiere opened this issue Jun 6, 2024 · 0 comments
Open

Tracking React 19 #362

SeanCassiere opened this issue Jun 6, 2024 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@SeanCassiere
Copy link
Owner

SeanCassiere commented Jun 6, 2024

Tracking anything currently that I think needs some resolution before I can ship React 19.

Tracking matrix

Project Comments Issue(s) PR(s)
Radix-UI Breaking radix-ui/primitives#2769
radix-ui/primitives#2933
radix-ui/primitives#2934
Recharts Breaking recharts/recharts#4558 N/A
Cmdk Installation peer-dep warning pacocoursey/cmdk#266 N/A
React Hook Form Installation peer-dep warning react-hook-form/react-hook-form#11932 react-hook-form/react-hook-form#11935
React Hook Form Breaking react-hook-form/react-hook-form#11910 useWatch

Basically, I need something relatively not too buggy before I move over (like a beta or rc).

Comments

Just whatever comments I have regarding the tracking process here.

✅ radix-ui

  • React 19 support is being tracked in the open PR.
  • The branch has been merged in and released as a 'release candidate' under the next tag (-rc.4).
  • Radix has pushed the changes to main.

🚨 recharts

  • React 19 support is being tested in the releases tagged under alpha.

🚨 cmdk

  • The packages uses primitives by radix-ui, so it can be expected that React 19 support should follow soon after the Radix PR goes through.

✅ react-hook-form

  • The form.watch doesn't work when the react-compiler is turned on, unless you memorize the watcher with an eslint ignore.
const form_checkoutDate = React.useMemo(
    () => form.watch("checkoutDate"),
    // eslint-disable-next-line react-compiler/react-compiler
    // eslint-disable-next-line react-hooks/exhaustive-deps
    [form.watch("checkoutDate")]
);
  • The workaround is to use the useWatch hook to not have to trick the react-compiler using useMemo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant