-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoiseProcess type hierarchy #209
Comments
It would be fine to add one if you have a sensible breakdown you're interested in. |
I was thinking of making every NoiseProcess their own subtype with the same fields as Alternatively, we can just add another field with the name of the process. |
AbstractNoiseProcess, yes |
I was trying some things out and came across the classic inheritance vs. composition dilemma. Initially, I envisioned an inheritance approach where The alternative is to use composition: struct WienerProcess <: AbstractNoiseProcess
process::NoiseProcess
end With this approach, I would need to define functions like: process(x::WienerProcess) = x.process
process(x::NoiseProcess) = x This way, I can use One drawback of using types is the additional need to define in-place versions, like |
To implement when which algorithm is compatible with which noise type we need to distinguish between them after creation. Would it be sensibele to make a type system on top of
NoiseProcess
? The CamelCase names seems already to suggest that we should think of them this way.SciML/SciMLBase.jl#774
The text was updated successfully, but these errors were encountered: