Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in vanity constants #10

Open
AndreaLanfranchi opened this issue Apr 28, 2020 · 3 comments
Open

Typo in vanity constants #10

AndreaLanfranchi opened this issue Apr 28, 2020 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation hardfork wontfix This will not be worked on

Comments

@AndreaLanfranchi
Copy link

AndreaLanfranchi commented Apr 28, 2020

Looking at https://github.com/RavenCommunity/kawpowminer/blob/master/libethash-cuda/CUDAMiner_kernel.cu#L33-L49

Capital R has been assigned hex code 0x72 which in reality is r (lower case)
Correct hex code should be 0x52.
Implementers iterating chars through string "RAVENCOINKAWPOW" get different constants thus have not matching results.

@AndreaLanfranchi
Copy link
Author

An amendment of this implies amendment in verification tool thus on node and pool software

@blondfrogs
Copy link

Great find. I think at this moment we will just edit the comments to reflect rAVENCOIN. We have been able to get other miners already built and right now a change like this so close to the fork isn’t feasible. Great find! Luckily this doesn’t impact security

@AndreaLanfranchi
Copy link
Author

Ok then.
As there's only this reference implementation for kawpow keep the issue open and pinned.

@AndreaLanfranchi AndreaLanfranchi pinned this issue Apr 28, 2020
@blondfrogs blondfrogs added wontfix This will not be worked on typo hardfork documentation Improvements or additions to documentation and removed typo labels May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hardfork wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants