Add PiecewiseSRM to the package

[thomasbazeille]

Goal : Piecewise SRM

Main questions :

• How to handle IdentifiableSRM dependency ? import a copy of [Hugo's package] code (https://github.com/hugorichard/FastSRM) (that should maybe become the upstream then) or depend on the package
• Should we change the API ? As of now it seems hard to match it to other fmralign objects more than it already is

Other than that, main depencies are compatible and fmralign helpers are already used. A few functions are duplicated to handle the list input (instead of pairwise input usually) such as generate_X_is, fit_one_piece, fit_one_parcellation. We could either refactor their counterpart in fmralign, or keep the duplication in order to keep a clearer codebase.

[bthirion]

I'd rather import it, but you seem to be reluctant to that, and I'm not sure why ?
API change: to be discussed with @hugo
Deduplication would be great. Maybe aligning the FastSRM to the cogalign one seems a right option, as you ahve worked more on the API I guess.

[thomasbazeille]

I'd rather import it, but you seem to be reluctant to that, and I'm not sure why ?

I guess it is mostly a question of future maintenance and involvement. Having a strong dependency on a personal package seems like something that's likely to make things break if it is not maintained and bringing everything in the same place also means centralizing future maintenance but I don't have a strong opinion.

[emdupre]

Personal +1 that a central location might decentralize maintenance, but @hugorichard 's opinion is probably the most pressing, here !

[thomasbazeille]

Maybe my bad wording in the first place introduced a misunderstanding. If by

I'd rather import it, but you seem to be reluctant to that, and I'm not sure why ?

you mean we should have a copy of one SRM inside fmralign, then I think we all agree.

[hugorichard]

I would rather import it. FastSRM is already used in Multiview ICA. Maybe I could remove this dependency though. I need to think about it.

[bthirion]

+1 for import (sorry if I was unclear)

[thomasbazeille]

@hugorichard did you have any time to think about this ?

[hugorichard]

Should I include our implementation here as a PR ?

[bthirion]

Yes, please add a PR that imports FastSRM properly. Thx !

[hugorichard]

@thomasbazeille @bthirion I have added a PR #50 . CircleCI seem to be broken (the tests do not even run).