Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: docker-machine is deprecated, we need to add support for another tool for autoscaling #88

Open
gromain opened this issue Feb 1, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@gromain
Copy link
Contributor

gromain commented Feb 1, 2022

docker-machine is being deprecated and starts to be unavailable from repositories. It's also not compatible with the latest docker version. See docker/machine#4537 and docker/roadmap#245 .

One alternative would be to move towards Terraform. There is a provider for Scaleway, so we wouldn't lose functionality. Is there any interest in moving towards this solution?

What is the problem?

docker-machine being deprecated.

What should be the expected behavior?

Not losing the autoscale!

How can we reproduce this? (What steps did you do to trigger the problem? If applicable, please include multiple screenshots of the problem! Be detailed)

Try installing docker-machine on a recent OS.

@gromain
Copy link
Contributor Author

gromain commented Feb 1, 2022

A python alternative could be libcloud (I know this tool is written in JS, just mentioning this for posterity): https://libcloud.apache.org/

@pierotofy pierotofy added the enhancement New feature or request label Feb 1, 2022
@pierotofy
Copy link
Member

Definitely interested in possible approaches to migrate away from docker-machine, although docker-machine is open source, so it continues to receive support from various organizations (e.g. gitlab https://gitlab.com/gitlab-org/ci-cd/docker-machine) and has been working OK thus far, so I don't think we're losing autoscaling anytime soon.

@gromain
Copy link
Contributor Author

gromain commented Feb 1, 2022

Ah yes, this is good then!
Maybe we can just update the Readme to point to this new repo, instead of towards https://docs.docker.com/machine/install-machine/ . It was really confusing for me!

@gromain gromain changed the title docker-machine is deprecated, we need another tool for autoscaling [Feature Request]: docker-machine is deprecated, we need to add support for another tool for autoscaling Feb 1, 2022
@gromain
Copy link
Contributor Author

gromain commented Feb 1, 2022

I've fixed the documentation, Dockerfile and docker-compose files.
This will do for now, but I suggest we keep this open to make sure the tool is not completely abandoned by Gitlab and we keep looking for another solution.

@pierotofy
Copy link
Member

pierotofy commented Feb 1, 2022

Thanks. As a heads up, I've reverted the docker-compose file changes since not everyone uses the autoscaling functionality (perhaps those changes should be part of a separate docker-compose file).

@gromain
Copy link
Contributor Author

gromain commented Feb 2, 2022

Oh I see, I thought the docker-composer file here was only for the autoscaler (since this was in the autoscaler section of the readme too and there is specific instructions about starting it up with one child nodeodm).
I'll create a separate one and update the readme accordingly.

@theoway
Copy link

theoway commented Jul 22, 2022

A python alternative could be libcloud (I know this tool is written in JS, just mentioning this for posterity): https://libcloud.apache.org/

@pierotofy Can we not migrate to Terraform? It is very widely supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants