Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to generate SEDML file from LEMS and use this as master in exported OMEX archive #329

Open
pgleeson opened this issue Apr 9, 2024 · 0 comments · Fixed by #335
Assignees
Labels
good first issue A good issue for newcomers to work on Help wanted T: enhancement Type: enhancement

Comments

@pgleeson
Copy link
Member

pgleeson commented Apr 9, 2024

For upload to https://biosimulations.org/runs/new

Example of valid manifest file using SEDML:

<?xml version="1.0" encoding="UTF-8"?>
<omexManifest xmlns="http://identifiers.org/combine.specifications/omex-manifest">
  <content location="model.xml" format="http://purl.org/NET/mediatypes/application/lems+xml" master="false"/>
  <content location="simulation.sedml" format="http://identifiers.org/combine.specifications/sed-ml" master="true"/>
  <content location="NaConductance.channel.nml" format="http://identifiers.org/combine.specifications/neuroml" master="false"/>
  <content location="KConductance.channel.nml" format="http://identifiers.org/combine.specifications/neuroml" master="false"/>
  <content location="LeakConductance.channel.nml" format="http://identifiers.org/combine.specifications/neuroml" master="false"/>
  <content location="NML2_SingleCompHHCell.nml" format="http://identifiers.org/combine.specifications/neuroml" master="false"/>
  <content location="metadata.rdf" format="http://identifiers.org/combine.specifications/omex-metadata" master="false"/>
  <content location="expected-results.json" format="http://purl.org/NET/mediatypes/application/json" master="false"/>
  <content location="reports.h5" format="http://purl.org/NET/mediatypes/application/x-hdf" master="false"/>
</omexManifest>

What needs to be done here:

  • the SEDML file needs to be generated from LEMS by running jneuroml with -sedml: see pynml.py and search for the -sedml arg there
  • we already have functionality to create the OMEX archive by pointing at LEMS/NeuroML files, so that can be extended to also use a SEDML file. (Note that to get the file pointed to by the SEDML file, one will have to parse the SEDML file, or one can get it from the LEMS file that is being used to generate the SEDML file)
@sanjayankur31 sanjayankur31 added T: enhancement Type: enhancement good first issue A good issue for newcomers to work on Help wanted labels Apr 16, 2024
@sanjayankur31 sanjayankur31 self-assigned this Apr 17, 2024
@sanjayankur31 sanjayankur31 linked a pull request Apr 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good issue for newcomers to work on Help wanted T: enhancement Type: enhancement
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants