Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook doesn't triggers if in saved whm repourl field not ends with .git #52

Open
inhumanitas opened this issue Dec 27, 2017 · 1 comment

Comments

@inhumanitas
Copy link
Contributor

Add web hook mapping.
Fill "Repourl" as copy from browser(wtihout .git at the end), eg, from github.
Other fields does not matter.

Incoming webhook will be with .git at the end, so new created webhook would not be triggered.

Solution:
store repourl with .git at the end, add .git if doesn't ends with it.

@keto
Copy link
Member

keto commented Feb 14, 2018

Usually it is not necessary to create the webhook mappings manually. The service should create a placeholder with the correct repourl when it gets first event from the repo. After that you just need to set the project, package and other parameters.

The repourl is a bit problematic also in other ways. Same repository can be referenced with different kind of URLs, the backends possibly need to access the repo with specific transport, etc. To solve this the plan is (possibly) to switch to identifying the repositories with vcs service and repository path/name, instead of full URL. And then dynamically constructing the URL from those where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants