New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seed generators in benchmarks #10

Open

Niols opened this issue May 18, 2020 · 0 comments

Member

Niols commented May 18, 2020

Shouldn't we seed the Random generators (on similar seeds) before testing? Like go from:

ocaml-rng-experiments/prng/src/bench.ml

Lines 28 to 29 in e29fb07

    
           B.Test.create ~name:"Random.float" (fun () -> 
        
               Random.float 1.);

to something like:

B.Test.create_with_initialization ~name:"Random.float" (fun `init ->
    Random.init 4; (* please don't *)
    fun () -> Random.float 1.);

(untested; from memory; might not be exactly this)

Niols mentioned this issue

Reorganisation of the repo structure #4

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment