You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In writeTopologyLevel1, the option of printID=true means that only branch lengths that are identifiable will be printed. The function first changes all non-identifiable branch lengths to -1, and then write the parenthetical format. This is confusing because the function is in fact modifying an argument (the network) and it does not end in !. Also, it is difficult to debug when a function that is meant to simply write the parenthetical format changes the actual network object.
An easy fix could be to do a deepcopy of the network object at the beginning of writeTopologyLevel1, but it might be worth to re-thinking the role of writeTopologyLevel1 with the update of root and non-identifiable BLs at the end of snaq!.
The text was updated successfully, but these errors were encountered:
Instead of doing a deep copy of the full network, could the vector of branch lengths be saved, e.g. [e.length for e in net.edge], so that edge lengths can be restored afterwards?
In
writeTopologyLevel1
, the option ofprintID=true
means that only branch lengths that are identifiable will be printed. The function first changes all non-identifiable branch lengths to -1, and then write the parenthetical format. This is confusing because the function is in fact modifying an argument (the network) and it does not end in !. Also, it is difficult to debug when a function that is meant to simply write the parenthetical format changes the actual network object.An easy fix could be to do a deepcopy of the network object at the beginning of
writeTopologyLevel1
, but it might be worth to re-thinking the role ofwriteTopologyLevel1
with the update of root and non-identifiable BLs at the end ofsnaq!
.The text was updated successfully, but these errors were encountered: