Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if seekstart after write deletes data. #157

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Oct 16, 2023

This PR adds tests showing that currently calling seekstart on a stream in write mode can silently delete data.

@nhz2 nhz2 changed the title Test if seekstart deletes user data. Test if seekstart after write deletes data. Oct 16, 2023
@nhz2 nhz2 changed the title Test if seekstart after write deletes data. Test if seekstart after write deletes data. Oct 16, 2023
@mkitti
Copy link
Member

mkitti commented Oct 17, 2023

So both the tests here are broken? Is the plan to unbreak them?

@nhz2
Copy link
Member Author

nhz2 commented Oct 17, 2023

Yes. For the QuadrupleCodec case I think the fix is to have the fallback TranscodingStream seekstart throw an ArgumentError if the stream is not in read or idle mode. For the NoopCodec case, I think the solution is a little trickier because it doesn't use the fallback seekstart.

@mkitti
Copy link
Member

mkitti commented Oct 17, 2023

Should we merge this then or are we waiting for something?

@nhz2 nhz2 merged commit 00f2fdb into JuliaIO:master Oct 17, 2023
18 checks passed
@nhz2 nhz2 deleted the seek-write-mode branch October 17, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants