Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update / replace Libz registration for .gz files #316

Open
kescobo opened this issue Mar 15, 2021 · 3 comments
Open

Update / replace Libz registration for .gz files #316

kescobo opened this issue Mar 15, 2021 · 3 comments

Comments

@kescobo
Copy link
Member

kescobo commented Mar 15, 2021

See BioJulia/Libz.jl#68

Libz.jl is no longer maintained, and now recommends folks use CodecZlib instead. In any case, the implementation for Libz.jl is no longer functional.

julia> FileIO.load("test.log.gz")
Error encountered while load File{DataFormat{:GZIP}, String}("test.log.gz").

Fatal error:
ERROR: UndefVarError: load not defined
@timholy
Copy link
Member

timholy commented Mar 16, 2021

Did it ever work? Libz doesn't even load FileIO.

I'm happy to make the change, but first I want to just check that there's nothing broken here.

@kescobo
Copy link
Member Author

kescobo commented Mar 16, 2021

Oh, no idea 😆

The FileIO docs point to Libz as being used for .gz files. I would not be surprised if that connection is not maintained if there were changes to the FileIO interface at somepoint in the last 2 years.

@CiaranOMara
Copy link
Contributor

CodecZlib.jl doesn't appear to implement the FileIO loaders or savers either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants