clarifies stream seeking for querying and detection functions #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssfrr
force-pushed
the
detect-positioning
branch
from
c451aa1
to
11a8921
Compare
|
Ugh, I just noticed this. If you want something like this it will likely be easier to start from scratch. I am not 100% certain we've been as careful as we should be about the stream position upon exit, or even what the right default really is. Maybe the detector should leave the position as-is after successful detection? Happy to help you get this over the finish line if you're still interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query infrastructure was already handling seeking around the stream
before and after calling the detect functions, so they shouldn't have to
worry about it. This also sets the example in the README to skip the magic
bytes in
load(::Stream)instead ofload(::File).fixes #163