Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support only_best option #87

Open
2 tasks done
visr opened this issue Jul 14, 2023 · 2 comments
Open
2 tasks done

support only_best option #87

visr opened this issue Jul 14, 2023 · 2 comments

Comments

@visr
Copy link
Member

visr commented Jul 14, 2023

Edit: see post below about the only_best option that is new in PROJ 9.2.

PROJ 9.2.1 is already picked up by this package through PROJ_jll v900.200.100.

@visr
Copy link
Member Author

visr commented Jul 21, 2023

The two remaining test failures can be fixed by enabling network access for those transformations. Otherwise we get these separate errors:

hgridshift: could not find required grid(s)
vgridshift: could not find required grid(s)

using Proj
Proj.enable_network!(false)
trans2 = Proj.Transformation("EPSG:32632", "EPSG:2027", always_xy = true) # fails, passed before, passes with network

I suspect this is related to the new ONLY_BEST option. This option looks like a great addition, but as I understand the PR it shouldn't break anything since it defaults to off. So I don't understand why it would affect our tests. This need some more investigation.

https://proj.org/en/9.2/news.html#id20
OSGeo/PROJ#3535

Also perhaps we should add some support for the option just like pyproj:

pyproj4/pyproj#1236

@visr visr mentioned this issue Aug 6, 2023
@visr visr changed the title update for PROJ 9.2.1 support only_best option Aug 25, 2023
@evetion
Copy link
Member

evetion commented Aug 26, 2023

I don't mind this breaking change, it should be the default imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants