Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc generation is failing silently #1045

Closed
1 of 2 tasks
ablaom opened this issue Aug 27, 2023 · 2 comments
Closed
1 of 2 tasks

Doc generation is failing silently #1045

ablaom opened this issue Aug 27, 2023 · 2 comments
Labels
docs

Comments

@ablaom
Copy link
Member

ablaom commented Aug 27, 2023 •
edited
Loading

https://github.com/alan-turing-institute/MLJ.jl/actions/runs/5993524023/job/16254036811?pr=1044#step:6:812

To do:

  • Fix the "silence" of fail
  • Fix the cause of fail
@ablaom ablaom added the docs label Aug 27, 2023
@DilumAluthge
Copy link
Member

You likely want to set strict = true in the makedocs function. This should cause the failure to be visible (rather than silent).

@ablaom
Copy link
Member Author

ablaom commented Aug 27, 2023

Thanks for the suggestion. Sadly, we have that already, no?

https://github.com/alan-turing-institute/MLJ.jl/blob/7c677a2f28a41b426aa6c80ff3cc823912661f73/docs/make.jl#L117

@DilumAluthge DilumAluthge mentioned this issue Aug 28, 2023
Merged
@ablaom ablaom mentioned this issue Sep 4, 2023
Merged
@ablaom ablaom closed this as completed Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DilumAluthge @ablaom