Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_wrapper(::RFE) should return true not false #15

Closed
ablaom opened this issue Jun 5, 2024 · 2 comments · Fixed by #22
Closed

is_wrapper(::RFE) should return true not false #15

ablaom opened this issue Jun 5, 2024 · 2 comments · Fixed by #22
Assignees
@OkonSamuel
Labels
bug Something isn't working

Comments

@ablaom
Copy link
Member

ablaom commented Jun 5, 2024 •
edited
Loading 

julia> is_wrapper(FeatureSelection.RFE)
false

And this line should be removed:

FeatureSelection.jl/src/models/rfe.jl

Line 352 in ec0eb11

:is_wrapper,

@ablaom ablaom added the bug Something isn't working label Jun 5, 2024
@ablaom ablaom changed the title is_wrapper(::RecursiveFeatureElimination) should return true not false is_wrapper(::RFE) should return true not false Jun 5, 2024
@OkonSamuel
Copy link
Member

closed by #18

@ablaom ablaom reopened this Jul 18, 2024
@ablaom
Copy link
Member Author

ablaom commented Jul 18, 2024 

julia> using FeatureSelection

julia> using MLJBase

julia> is_wrapper(RecursiveFeatureElimination)
false

(jl_Za1kOv) pkg> st
Status `/private/var/folders/4n/gvbmlhdc8xj973001s6vdyw00000gq/T/jl_Za1kOv/Project.toml`
  [33837fe5] FeatureSelection v0.2.0
  [a7f614a8] MLJBase v1.6.0

This is causing the fail here and will require another re-release of MLJModels to update the model registry to fix.

@OkonSamuel

@OkonSamuel OkonSamuel mentioned this issue Jul 28, 2024
Merged
@ablaom ablaom closed this as completed Jul 28, 2024
@ablaom ablaom mentioned this issue Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OkonSamuel OkonSamuel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set MMI is_wrapper trait as true JuliaAI/FeatureSelection.jl
2 participants
@ablaom @OkonSamuel