Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.0.5] Old life cycle warning - AutosizeInput #3773

Closed
devlemire opened this issue Sep 23, 2019 · 9 comments · Fixed by #3787
Closed

[v3.0.5] Old life cycle warning - AutosizeInput #3773

devlemire opened this issue Sep 23, 2019 · 9 comments · Fixed by #3787

Comments

@devlemire
Copy link

devlemire commented Sep 23, 2019

I'm aware that this is an active issue that many users are aware of. However, from what I read it looks like one last warning got swept under the carpet while celebrating the release of 3.0.5. Which by the way, thank you for this, it cleared up a TON of warnings in my Unit Tests.

However... there is one last warning that wasn't taken care of. It occurs in the AutosizeInput component and it uses "componentWillReceiveProps" This is the last warning that is clogging my tests and my console in my dev tools. I would really love to see a fix for this.

Again thanks for everything you've done thus far, I'm very grateful. Here's what my console says:

console.warn node_modules/react-dom/cjs/react-dom.development.js:11494
      Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

      * Move data fetching code or side effects to componentDidUpdate.
      * If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
      * Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

      Please update the following components: AutosizeInput
@devlemire devlemire changed the title [v3.0.5] Old life cycle warning [v3.0.5] Old life cycle warning - AutosizeInput Sep 23, 2019
@mpopv
Copy link

mpopv commented Sep 23, 2019

Duplicate of #3720

@julien51
Copy link

This is not quite a duplicate and more like a regression as this issue #3720 should have indeed been fixed by the 3.0.5?

@ranneyd
Copy link

ranneyd commented Sep 23, 2019

@gwyneplaine
Copy link
Collaborator

@devlemire I don't have publishing rights to react-input-autosize, but I'll have a chat with @JedWatson to get this sorted ASAP, thanks for bringing this to our attention

@devlemire
Copy link
Author

Thank you for your time!

@ranneyd
Copy link

ranneyd commented Sep 24, 2019

Gonna drop this guy here, since it's necessary for getting this lib fixed.

JedWatson/react-input-autosize#167

@ranneyd
Copy link

ranneyd commented Sep 25, 2019

#3720 (comment)

@devlemire
Copy link
Author

@gwyneplaine Were you able to get in contact? Sorry for the constant annoyance. It looks like a PR is available to solve the issue.

@erwanriou
Copy link

+1
Awaiting feedback. Go the exact same issue now that i started update all my react libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants