-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
idr0010-doil-dnadamage S-BIAD885 #641
Comments
Imported 1 ome.zarr plate into OMERO. http://localhost:1080/webclient/?show=plate-202 Time taken for the import 1 hour |
Started conversion of full dataset on pilot-zarr2-dev. |
Installed minio client on I see that currently 62 / 148 plates have been converted so far (in ~22 hours) so will need another day... |
Started to copy some data over. Can copy the rest once done, but this allows me to start import etc...
|
The copy above is showing some errors...
But these objects do exist. e.g:
However, they are not uploaded so cause 404 and other errors - plate won't display at https://hms-dbmi.github.io/vizarr/?source=https://uk1s3.embassy.ebi.ac.uk/idr0010/zarr/120.ome.zarr This was fixed with: (no errors):
Repeated for others above. |
Weird... at least it worked on the second copy attempt. |
We get one plate that isn't in the released study
Repeat the copy:
|
Last plate to be processed: https://ome.github.io/ome-ngff-validator/?source=https://uk1s3.embassy.ebi.ac.uk/idr0010/zarr/99.ome.zarr One more plate that in IDR, extra
|
@dominikl tried following #656 with idr0010 plates yesterday and got the same error that I got previously after updating symlinks: NB: Plate import there takes 20 minutes. Restarted import of all idr0010 plates just now to test again... (idr0125-pilot, http://localhost:1080/webclient/?show=screen-3202 |
Try again: NB: Using Import a single plate without chunks...
Symlinks...
Plate looks good! 👍 Fileset swap...
|
We are seeing a different Well ordering issue on this Plate:
cc @dgault |
Checked that https://hms-dbmi.github.io/vizarr/?source=https://uk1s3.embassy.ebi.ac.uk/idr0010/zarr/99.ome.zarr looks good compared with https://idr.openmicroscopy.org/webclient/?show=plate-5936, so the NGFF looks valid, even if we still have issues importing / viewing in OMERO. So, good to go ahead with zip and upload to BioStudies without waiting on ZarrReader issues above.... |
On
|
Last time I checked zip creation after running zip command above, it was mostly complete...
But not it seems all of
|
Sorry, accidentely deleted the zarrs on pilot-zarr2-dev... thought it was already submitted to biostudies. I'll start the conversion again. |
Running
now (in /data/ngff/idr0010) |
The ZarrReader PR ome/ZarrReader#53 has been updated to try and improve the reordering behaviour to hopefully solve the issue seen in #641 (comment) |
Checking counts of plates on https://www.ebi.ac.uk/biostudies/submissions/files?path=%2Fuser%2Fidr0010 I see that there are 149 zips there but only 148 at https://idr.openmicroscopy.org/webclient/?show=screen-1351 Using this JS Code on the biostudies page to find the difference ...
Returns:
This Plate doesn't appear in IDR - maybe it got removed from the submission for some reason? |
Specifically on #641 (comment). A few comments:
It might be worth looking into the history of this submission to see if a workaround and/or an alternative binary file could be found with the correct dimensions in which case a reimport might be in scope. Otherwise, a cleanup solution would be to de-annotate and delete this broken plate from production IDR in an upcoming release. /cc @francesw @will-moore |
Looking in I don't have access to any of the historical discussion of this study. Was this on Trello (before Redmine)? Thinking this is probably best to delete that plate |
Updating
This has no effect on the Images that are shown for each Well in the plate above. |
Testing delete of Plate This first command took a very long time. Left running overnight!
Then we delete Plate...
|
TODO (still testing on idr0138-pilot):
I'm wondering if this is really the best course of action, since we lose a lot of study results by deleting them from the OMERO.table. That leaves open the possibility that we fix the images in future (if a user wants to work with the data)? |
Decision in IDR meeting on Monday was not to extend the NGFF work to include unrelated cleanup work. There is still a ZarrReader issue outstanding for idr0010, but the data is ready to be submitted to BioStudies... |
Deleted |
Testing
|
....Got 142 (out of 147) sql scripts generated so far and cancelled it because I need to restart server - SECRET will be invalid in all these scripts. In nearly 22 hours, 142 filesets processed -> 7 filesets an hour - 9 mins each. |
On idr-testing, as
|
idr0010-doil-dnadamage
The text was updated successfully, but these errors were encountered: