Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Components][Departments] #15

Open
atherdon opened this issue Oct 24, 2018 · 7 comments
Open

[Components][Departments] #15

atherdon opened this issue Oct 24, 2018 · 7 comments

Comments

@atherdon
Copy link
Member

  • title (1)
  • part of autocomplete (2)
  • title, id (3)
  • List items (4)
  • Department accordeon (5)
  • list items with link to view departmentInfo (6)
  • list items with Edit, Delete (7)

Simple tasks

  • simple text, i.e. Label (8)
  • text with id props (9)
  • title+ link to department info (10)

Departments List View (11)
Title + link - related to one Grocery list (12)

Route grocery/id/department_id
Route grocery/full/id
-> flexbox items with Department title, List of ingredients + checkboxes

@GuiFSs
Copy link

GuiFSs commented Nov 23, 2018

Hi @atherdon , can you explain this task to me?

@atherdon
Copy link
Member Author

GroceriStar/react-shopping-list-template@caae6fe
You should look @GuiFSs at this commit of Vadim, i think it helps to understand what we're doing here.

My idea that we should create very simple components, that later will be our building blocks of pages.
So i sit and write down every component that we should have, related to departments of food.
These components should be easy to do and maintain later. but they will help us a lot. We also maybe will move them away into a separated plugin - because i think it'll make our project better

@atherdon
Copy link
Member Author

tell me if something is not clear

@GuiFSs
Copy link

GuiFSs commented Nov 25, 2018

hmm, i saw the simple components that vadim created, but it's not clear for me the components that i should create, because i saw that he created the components Label, EditLink, Checkbox, etc.

@atherdon
Copy link
Member Author

all components, mentioned at this task should be created from scratch,
maybe some of the components have intersections with components, that Vadim created, but it's only for now.
Maybe you should keep all components that you'll create inside the Departments folder. and you'll not be able to mix up them with Vadim components.Feel free to use them as inspiration for your task.

So, for the first part of this task - you should create 12 components.

GuiFSs referenced this issue in GuiFSs/react-shopping-list-template Nov 25, 2018
@GuiFSs
Copy link

GuiFSs commented Nov 25, 2018

@atherdon i created some components, i would like you to see if this is what you expected.

atherdon referenced this issue in GroceriStar/react-shopping-list-template Nov 25, 2018
add some components from #67
@atherdon
Copy link
Member Author

for a quick looks - everything fine. will take a deeper look a bit later.

@atherdon atherdon transferred this issue from GroceriStar/react-shopping-list-template Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants