Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect helpers like middleware correctly #533

Open
3 tasks
atherdon opened this issue Jun 25, 2018 · 3 comments
Open
3 tasks

Connect helpers like middleware correctly #533

atherdon opened this issue Jun 25, 2018 · 3 comments

Comments

@atherdon
Copy link
Member

Description/Steps to reproduce

We should plan an upgrade for this middleware helpers

  • like-middleware-helper.js
  • grocery-middleware.js
  • ultimate-middleware.js

Expected result

Additional information

@JorgeRodr
Copy link

@atherdon I don't feel like it could be useful. I mean, if you want me to do it I will do it that's for sure, but here is the case (correct me if I am wrong):

Implement middlewares involves that every single request will pass through that middleware, or that is what I understand. This three helpers are been used only in certain points of the code, not every single request uses them so I think that implement them as middlewares will cause problem. Also, we probably will have to refactor some code to get it done right.

Again, maybe I am not understanding the middleware concept so if you think I'm wrong please report to me hahaha.

@atherdon
Copy link
Member Author

atherdon commented Jul 1, 2018 via email

@atherdon
Copy link
Member Author

atherdon commented Jul 1, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants