Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the manifest is already grouped #1041

Open
2 tasks
zanete opened this issue Oct 7, 2024 · 3 comments
Open
2 tasks

Check if the manifest is already grouped #1041

zanete opened this issue Oct 7, 2024 · 3 comments
Assignees
Milestone

Comments

@zanete
Copy link

zanete commented Oct 7, 2024

Why:
To resolve errors in if-check script and prevent error in edge case where user regroups an already-grouped manifest.

What:

Add a check to see if the manifest is already grouped according to the config. If the manifest is already grouped according to the given config, we should simply skip the regroup step.

The current behaviour, that we want to fix, is that the manifest regroup feature executes even the manifest is already grouped, which leads to additional, unnecessary levels of nesting.

Scope of work:

  • implement acceptance criteria
  • test cases added

Acceptance criteria

Scenario 1:

The following manifest:

# start
name: regroup
description: successful path
initialize:
  plugins: {}
tree:
  children:
    my-app:
      pipeline:
        regroup:
          - cloud/region
          - cloud/instance-type
      children:
        uk-west:
          children:
            A1:
              inputs:
                - timestamp: 2023-07-06T00:00
                  duration: 300
                  cloud/instance-type: A1
                  cloud/region: uk-west
                  cpu/utilization: 99
                - timestamp: 2023-07-06T05:00
                  duration: 300
                  cloud/instance-type: A1
                  cloud/region: uk-west
                  cpu/utilization: 23
                - timestamp: 2023-07-06T10:00
                  duration: 300
                  cloud/instance-type: A1
                  cloud/region: uk-west
                  cpu/utilization: 12
            B1:
              inputs:
                - timestamp: 2023-07-06T00:00
                  duration: 300
                  cloud/instance-type: B1
                  cloud/region: uk-west
                  cpu/utilization: 11
                - timestamp: 2023-07-06T05:00
                  duration: 300
                  cloud/instance-type: B1
                  cloud/region: uk-west
                  cpu/utilization: 67
                - timestamp: 2023-07-06T10:00
                  duration: 300
                  cloud/instance-type: B1
                  cloud/region: uk-west
                  cpu/utilization: 1

Should return the same exact file when run using if-run --regroup -m <manifest> (except for adding an execution node to context)

@zanete zanete added this to the IF 1.0 milestone Oct 7, 2024
@jmcook1186
Copy link
Contributor

@narekhovhannisyan added some detail to the ticket

@zanete
Copy link
Author

zanete commented Oct 10, 2024

Expecting a PR today

@zanete
Copy link
Author

zanete commented Oct 15, 2024

This issue needs to be re-refined, especially after a possible resolution will be found in relation to time grid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Parked
Development

No branches or pull requests

3 participants