Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should check that we don't build rustc_codegen_spirv more than once. #549

Open
eddyb opened this issue Mar 29, 2021 · 2 comments
Open
Labels
a: test Issues around testing rust-gpu. c: meta Issues specific to the GitHub repository. README, CI, etc. t: enhancement A new feature or improvement to an existing one.

Comments

@eddyb
Copy link
Contributor

eddyb commented Mar 29, 2021

See #546 for some context and ideas - especially #546 (comment).

Sadly, this is likely blocked on moving CI to use --release to build examples (which depend on "build dependency release mode rustc_codegen_spirv via the spirv-builder-using build scripts), otherwise the problem can't be reproduced in the first place (AFAIK).

@eddyb eddyb added t: enhancement A new feature or improvement to an existing one. c: meta Issues specific to the GitHub repository. README, CI, etc. a: test Issues around testing rust-gpu. labels Mar 29, 2021
@oisyn
Copy link
Contributor

oisyn commented Nov 16, 2022

Superseded by #911

@oisyn oisyn closed this as completed Nov 16, 2022
@eddyb eddyb reopened this Nov 23, 2022
@eddyb
Copy link
Contributor Author

eddyb commented Nov 23, 2022

Reopened because I think it's orthogonal to #911: we should find a way to detect redundant builds on CI regardless of what those build steps do internally.

Worst case this looks like checking that Compiling rustc_codegen_spirv appears only once in the build logs (though build script stdout/stderr is hidden by default so it would have to search in target/**/build/**/std{out,err} too).

Maybe all we need is a RUSTC_WRAPPER that adds the command to a "log file" and then we can check that e.g. --crate-name rustc_codegen_spirv appears only once (we'd have to make sure this gets propagated to build scripts tho).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: test Issues around testing rust-gpu. c: meta Issues specific to the GitHub repository. README, CI, etc. t: enhancement A new feature or improvement to an existing one.
Projects
None yet
Development

No branches or pull requests

2 participants