Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report more accurate printing progress #34

Open
woutgg opened this issue Feb 5, 2016 · 2 comments
Open

Report more accurate printing progress #34

woutgg opened this issue Feb 5, 2016 · 2 comments

Comments

@woutgg
Copy link
Contributor

woutgg commented Feb 5, 2016

With GCode buffering improvements currently being integrated, it becomes possible for clients to set the total of lines to be buffered beforehand.
To report more accurate progress (esp. with large prints), it would be good to use this number (if set by client) instead of current behaviour where the number of buffered lines so far is used.

A possible implementation would be to (don't mind the naming proposals):

  • rename getTotalLines() to getTotalAppendedLines(),
  • create new function (e.g., getGrandTotalLines) which returns sequenceTotal_ if set, or getTotalAppendedLines() otherwise.
    The new function would then be used for progress reports.
@woutgg
Copy link
Contributor Author

woutgg commented Feb 12, 2016

Update: the improvements do not actually make this possible, so a new parameter (e.g. total_lines) would have to be added to the printer/print API endpoint in firmware. With that information, the part about possible implementation can be done.

@woutgg
Copy link
Contributor Author

woutgg commented Feb 17, 2016

This has been implemented. See: client changes, firmware changes and print3d changes here and here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant