Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync bathymetry face_z and node_z array sizes with meshkernel #579

Open
veenstrajelmer opened this issue Nov 2, 2023 · 0 comments
Open
Labels
domain: mesh type: bug Something isn't working

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Nov 2, 2023

Is your feature request related to a problem? Please describe.
The bathymetry properties of Mesh2d and probably other classes are not synced with meskernel. In test_read_net_nc_2d_without_faces it happens that face_x.size=208 and face_z.size=0 (although node_z is not empty, so this is actually sort of correct). This is also the case with bathymetry clipping as was documented in Deltares/MeshKernel#326

Describe the solution you'd like
Some smartness in bathymetry setting/maintaining z-values. Preferably as part of meshkernel(py), but otherwise think of a way to handle it properly in hydrolib-core.

Maybe also for edge_z? This is currently no property of Mesh2d.

@priscavdsluis priscavdsluis added type: bug Something isn't working domain: mesh labels Apr 9, 2024
@veenstrajelmer veenstrajelmer changed the title Sync bathymetry face_z and edge_z sizes with meshkernel Sync bathymetry face_z and node_z array sizes with meshkernel Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: mesh type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants