Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check fileVersion numbers and define which version(s) we support #94

Open
arthurvd opened this issue Oct 21, 2021 · 0 comments · May be fixed by #180
Open

Check fileVersion numbers and define which version(s) we support #94

arthurvd opened this issue Oct 21, 2021 · 0 comments · May be fixed by #180
Assignees
Labels
domain: io priority: high type: compatibility Changes needed to be compatible with the computational core type: enhancement Improvements to existing functionality

Comments

@arthurvd
Copy link
Member

  • for each filetype, we should maintain what is the current fileVersion that HYDROLIB-core supports.
  • As such, after parsing a file, a check should be done on the file's fileVersion and the HYDROLIB-core supported fileVersion.
  • fileVersion numbers are now stored as a float, but note that we want to support this:
    2.1 --> major=2, minor=1
    2.10 --> major=2, minor=10
  • Suggestion for what forward/backward compatibility HYDROLIB-core should support:
    • file major < HYDROLIB major --> not supported
    • file major == HYDROLIB major and file minor <= HYDROLIB minor --> supported
    • file major == HYDROLIB major and file minor > HYDROLIB minor --> not supported
    • file major > HYDROLIB major --> not supported
  • A clean error message should appear in case of non-compatibility (something like "File too new/old for HYDROLIB-core readers."
@arthurvd arthurvd linked a pull request Dec 13, 2021 that will close this issue
@arthurvd arthurvd added this to the Release 0.4 milestone Jun 27, 2022
@arthurvd arthurvd added the type: enhancement Improvements to existing functionality label Jun 27, 2022
@arthurvd arthurvd removed this from the Release 0.4 milestone Dec 16, 2022
@priscavdsluis priscavdsluis added domain: io type: compatibility Changes needed to be compatible with the computational core priority: high labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: io priority: high type: compatibility Changes needed to be compatible with the computational core type: enhancement Improvements to existing functionality
Projects
Status: To do
Development

Successfully merging a pull request may close this issue.

3 participants