Check fileVersion numbers and define which version(s) we support #94

arthurvd · 2021-10-21T14:10:54Z

for each filetype, we should maintain what is the current fileVersion that HYDROLIB-core supports.
As such, after parsing a file, a check should be done on the file's fileVersion and the HYDROLIB-core supported fileVersion.
fileVersion numbers are now stored as a float, but note that we want to support this:
2.1 --> major=2, minor=1
2.10 --> major=2, minor=10
Suggestion for what forward/backward compatibility HYDROLIB-core should support:
- file major < HYDROLIB major --> not supported
- file major == HYDROLIB major and file minor <= HYDROLIB minor --> supported
- file major == HYDROLIB major and file minor > HYDROLIB minor --> not supported
- file major > HYDROLIB major --> not supported
A clean error message should appear in case of non-compatibility (something like "File too new/old for HYDROLIB-core readers."

arthurvd assigned evetion Oct 21, 2021

arthurvd linked a pull request Dec 13, 2021 that will close this issue

Add Version checks to all relevant models. #180

Draft

arthurvd added this to the Release 0.4 milestone Jun 27, 2022

arthurvd added the type: enhancement Improvements to existing functionality label Jun 27, 2022

arthurvd removed this from the Release 0.4 milestone Dec 16, 2022

priscavdsluis added domain: io type: compatibility Changes needed to be compatible with the computational core priority: high labels Apr 9, 2024

Provide feedback