Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible issue with TranslatePress in latest versions of Neve #4301

Open
rodica-andronache opened this issue Sep 15, 2024 · 2 comments · May be fixed by #4305
Open

Possible issue with TranslatePress in latest versions of Neve #4301

rodica-andronache opened this issue Sep 15, 2024 · 2 comments · May be fixed by #4305
Assignees
@girishpanchal30
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. question Can be used to identify issues that are asking a question about the code or how to use the project.

Comments

@rodica-andronache
Copy link
Contributor

Description

I was not able to replicate this.

This user wanted to upgrade from Neve 3.5.8 to the latest version, while using TranslatePress.
When switching to the newest version, none of the translations work anymore.

He pinpointed the issue with this symbol "←" which we use for the title in here https://github.com/Codeinwp/neve/blob/master/header-footer-grid/templates/components/component-logo.php#L49

He is wondering why we use that and if we can remove it.

Step-by-step reproduction instructions

I was not able to replicate this.

Screenshots, screen recording, code snippet or Help Scout ticket

https://secure.helpscout.net/conversation/2641939607/424322?viewId=212385

Environment info

No response

Is the issue you are reporting a regression

No
@rodica-andronache rodica-andronache added bug This label could be used to identify issues that are caused by a defect in the product. question Can be used to identify issues that are asking a question about the code or how to use the project. labels Sep 15, 2024
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Sep 15, 2024
@girishpanchal30 girishpanchal30 linked a pull request Sep 19, 2024 that will close this issue
Open
6 tasks
@girishpanchal30 girishpanchal30 linked a pull request Sep 19, 2024 that will close this issue
Fixed compatibility issue TranslatePress plugin #4305
Open
6 tasks
@girishpanchal30
Copy link
Contributor

@rodica-andronache I've reviewed the issue and was unable to replicate it.

He is wondering why we use that and if we can remove it.

To address this, I replaced the hardcoded icon with Unicode arrows.

Could you please ask the customer to test the changes using the PR build zip?

Thanks

@rodica-andronache
Copy link
Contributor Author

I've asked the user, but didn't get a reply so far. I'm waiting for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@girishpanchal30 girishpanchal30

Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. question Can be used to identify issues that are asking a question about the code or how to use the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed compatibility issue TranslatePress plugin Codeinwp/neve
3 participants
@rodica-andronache @pirate-bot @girishpanchal30