-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table with Null engine not created on cluster #327
Comments
I figure the quick fix for this is to update the logic in @classmethod
def get_on_cluster(
cls: Type[Self], cluster: str = '', materialized: str = '', engine: str = ''
) -> bool:
if cluster.strip():
return (
materialized in ('view', 'dictionary')
or 'distributed' in materialized
or 'Replicated' in engine
+ or engine in ('Null')
)
else:
return False |
Another relevant issue: #237 |
The current For example, I wanted to use it in a Perhaps instead of adding more and more cases to the if statement, we can refactor it to work by default when called, and fix the problems from its misuse in other macros? Or we should leave the current one as is since it is used everywhere, but make a This is a sincere suggestion, what do you think @benjamin-awd? Then you could use it with any type of Engine etc. and the conditional one can be used by those implementations that need more logic such as distributed/Replicated materializations.. |
@emirkmo I ended up creating a
This is a good point -- I prefer that option (something like this) that adds the ON CLUSTER clause to everything by default if the As a user, when I specify the |
Describe the bug
Tables with null engines are not created using the
ON CLUSTER
clauseSteps to reproduce
Expected behaviour
There should be an option to allow a null engine table to be created on cluster
Code examples, such as models or profile settings
Also tried defining the cluster via profiles.yml, but this makes no difference
The text was updated successfully, but these errors were encountered: