New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why do we only build distributed `test_architectures` if `MPI.Initialized`? #3879

Open

glwagner opened this issue Oct 29, 2024 · 0 comments

Labels

distributed 🕸️ testing 🧪

Member

glwagner commented Oct 29, 2024

This seems a brittle:

Oceananigans.jl/test/utils_for_runtests.jl

Line 34 in 9ffbee3

if MPI.Initialized() && MPI.Comm_size(MPI.COMM_WORLD) == 4

some bug that caused MPI not to be initialized would cause the tests to be worthless but it might not be detected.

glwagner added distributed 🕸️ testing 🧪 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment