-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does the show method for OrthogonalSphericalShellGrid
make sense?
#3808
Comments
It doesn't! It was designed essentially thinking of a cubed sphere panel in mind; it makes sense for those I believe. |
Hmm, I don't think y = latitude on a cubed sphere panel either, at least not for all the panels right? |
Here's a few things that I can think of that might help me understand the geometry of an arbitrary orthogonal grid:
|
Where the center of the grid is perhaps? |
That too! Although, that is already shown:
|
Yes it is. Just making sure we need it to stay. |
It might be usefull to show the maximum and minum spacing, and the location of the north poles in latitude and longitude |
Regarding spacing: I agree |
Yep. For a show method specific to the tripolar grid |
Here we are talking about the show method for Maybe some people want the only grid that matters to be the tripolar grid but that is not our current situation. |
For example for the tripolar grid it looks like this
This claims that whatever grid I've constructed is "RightConnected" in latitude. This doesn't really make sense to me... but let's set that aside (it's a separate issue with the tripolar grid).
The bigger issue is that the y-topology is NOT the "latitude topology" --- on an orthogonal spherical shell grid, "y" and "latitude" are different (that's the whole point, when they do coincide we are on a LatitudeLongitudeGrid).
We should design a good show method for this grid type. My impression is that the show method was copied from LatitudeLongitudeGrid. But we need to work a bit harder for OrthogonalSphericalShellGrid because it is more general. I think we should give information both about the coordinate system (lat, lon, z), and in addition to that and separately, give information about the logical arrangement of the grid (x, y, z), including the topology. The former is important for understanding the geography of the grid and the latter is important for understanding the discretization, and the two are distinct from one another. So the show method for this grid is going to be more involved than the others. I don't think we need to indicate whether the x, y directions are "variably spaced". That is useful for rectilinear and lat-lon grids, but not for general grids.
cc @navidcy @simone-silvestri
The text was updated successfully, but these errors were encountered: